netdev - Re: [PATCH v8 net-next 4/5] net: ena: PHC stats through sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250306173142.GU1955273@unreal>
Date: Thu, 6 Mar 2025 19:31:42 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Jakub Kicinski <kuba@...nel.org>, David Arinzon <darinzon@...zon.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	"Woodhouse, David" <dwmw@...zon.com>,
	"Machulsky, Zorik" <zorik@...zon.com>,
	"Matushevsky, Alexander" <matua@...zon.com>,
	Saeed Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>,
	"Liguori, Anthony" <aliguori@...zon.com>,
	"Bshara, Nafea" <nafea@...zon.com>,
	"Schmeilin, Evgeny" <evgenys@...zon.com>,
	"Belgazal, Netanel" <netanel@...zon.com>,
	"Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>,
	"Kiyanovski, Arthur" <akiyano@...zon.com>,
	"Dagan, Noam" <ndagan@...zon.com>,
	"Bernstein, Amit" <amitbern@...zon.com>,
	"Agroskin, Shay" <shayagr@...zon.com>,
	"Ostrovsky, Evgeny" <evostrov@...zon.com>,
	"Tabachnik, Ofir" <ofirt@...zon.com>,
	"Machnikowski, Maciek" <maciek@...hnikowski.net>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Gal Pressman <gal@...dia.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH v8 net-next 4/5] net: ena: PHC stats through sysfs

On Thu, Mar 06, 2025 at 04:40:55PM +0100, Andrew Lunn wrote:
> On Wed, Mar 05, 2025 at 06:36:37PM -0800, Jakub Kicinski wrote:
> > On Wed, 5 Mar 2025 16:33:10 +0100 Andrew Lunn wrote:
> > > > I asked them to do this.
> > > > They are using a PTP device as a pure clock. The netdev doesn't support
> > > > any HW timestamping, so none of the stats are related to packets.  
> > > 
> > > So how intertwined is the PHC with the network device? Can it be
> > > separated into a different driver? Moved into drivers/ptp?
> > > 
> > > We have already been asked if this means network drivers can be
> > > configured via sysfs. Clearly we don't want that, so we want to get
> > > this code out of drivers/net if possible.
> > 
> > Is it good enough to move the relevant code to a ptp/ or phc/ dir
> > under ...thernet/amazon/ena/ ? Moving it to ptp/ proper would require
> > some weird abstractions, not sure if it's warranted? 
> 
> mtd devices have been doing this for decades. And the auxiliary bus
> seems to be a reinvention of the mtd concepts.

No, it is not. MTD concepts are no different from standard
register_to_other_subsystem practice, where driver stays in
one subsystem to be used by another.

Auxillary bus is different in that it splits drivers to their logical
parts and places them in right subsystems.

Thanks