netdev - Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f14fdfe-379b-4718-812b-820c90f58e27@kernel.org>
Date: Thu, 6 Mar 2025 09:31:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swathi K S <swathi.ks@...sung.com>, krzk+dt@...nel.org,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, conor+dt@...nel.org,
 richardcochran@...il.com, mcoquelin.stm32@...il.com,
 alexandre.torgue@...s.st.com
Cc: rmk+kernel@...linux.org.uk, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 pankaj.dubey@...sung.com, ravi.patel@...sung.com, gost.dev@...sung.com
Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
 bindings

On 06/03/2025 08:44, Swathi K S wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: 06 March 2025 12:45
>> To: Swathi K S <swathi.ks@...sung.com>; krzk+dt@...nel.org;
>> andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
>> kuba@...nel.org; pabeni@...hat.com; robh@...nel.org;
>> conor+dt@...nel.org; richardcochran@...il.com;
>> mcoquelin.stm32@...il.com; alexandre.torgue@...s.st.com
>> Cc: rmk+kernel@...linux.org.uk; netdev@...r.kernel.org;
>> devicetree@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com;
>> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
>> pankaj.dubey@...sung.com; ravi.patel@...sung.com;
>> gost.dev@...sung.com
>> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
>> bindings
>>
>> On 05/03/2025 10:12, Swathi K S wrote:
>>> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
>>> Ethernet YAML schema to enable the DT validation.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>
>>> Signed-off-by: Ravi Patel <ravi.patel@...sung.com>
>>> Signed-off-by: Swathi K S <swathi.ks@...sung.com>
>>> ---
>>>  .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
>>>  .../bindings/net/tesla,fsd-ethqos.yaml        | 118 ++++++++++++++++++
>>>  2 files changed, 121 insertions(+), 2 deletions(-)  create mode
>>> 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
>>>
>>
>> I tried and did not see any differences, so point me exactly to any difference
>> in the binding (binding!) which would justify dropping review?
> 
> Added the following in the example given in DT binding doc:

OK, but that's an example, not the binding, so no new properties in the
binding.

> 
> assigned-clocks = <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
>                                 <&clock_peric PERIC_EQOS_PHYRXCLK>;
> assigned-clock-parents = <&clock_peric PERIC_EQOS_PHYRXCLK>;
> 
> Given the significance of these changes, I assumed the changes need to be reviewed again.

Adding standard properties to the example is not significant change. It
is really a minor change.



Best regards,
Krzysztof