netdev - Re: [PATCH net-next v3 00/10] eth: bnxt: maintain basic pkt/byte counters in SW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTXYF5gV+_ukWcE9=_yfyXuNZ99t07CVcQde2n5x0SsH-g@mail.gmail.com>
Date: Fri, 7 Mar 2025 14:25:51 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Michael Chan <michael.chan@...adcom.com>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net, netdev@...r.kernel.org, 
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch, 
	horms@...nel.org, pavan.chebbi@...adcom.com, przemyslaw.kitszel@...el.com
Subject: Re: [PATCH net-next v3 00/10] eth: bnxt: maintain basic pkt/byte
 counters in SW

On Fri, Mar 7, 2025 at 4:25 AM Michael Chan <michael.chan@...adcom.com> wrote:
>
> On Thu, Mar 6, 2025 at 7:25 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Thu, 6 Mar 2025 19:54:22 +0900 Taehee Yoo wrote:
> > > It seems that the driver is supposed to return qstats even if interface
> > > is down. So, I think bnxt driver needs to store the sw_stats when the
> > > interface is down.
> >
> > I think the driver already stores the stats on close and will report
> > them in "base" values. So all we need in per-queue callbacks is to
> > return early, when the interface is down?
>
> Yes, we can check if (!bp->bnapi) and return early.

Hi Jakub and Michael,
Thanks a lot for the review!

I checked that early return if the interface is down, It works well
without any problem.
So if you're okay with it, I would like to add this fix to my current patchset.
https://lore.kernel.org/netdev/20250306072422.3303386-1-ap420073@gmail.com

Thanks a lot!
Taehee Yoo