netdev - RE: [Intel-wired-lan] [PATCH intel-net v2] ice: fix reservation of resources for RDMA when disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58668A82A07F8D3DCC4B9159E5D52@SJ0PR11MB5866.namprd11.prod.outlook.com>
Date: Fri, 7 Mar 2025 07:04:47 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Jesse Brandeburg <jbrandeb@...nel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "Brandeburg, Jesse" <jbrandeburg@...udflare.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "kernel-team@...udflare.com"
	<kernel-team@...udflare.com>, "leon@...nel.org" <leon@...nel.org>, "Kitszel,
 Przemyslaw" <przemyslaw.kitszel@...el.com>, "Ertman, David M"
	<david.m.ertman@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH intel-net v2] ice: fix reservation of
 resources for RDMA when disabled



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jesse Brandeburg
> Sent: Thursday, March 6, 2025 6:57 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Brandeburg, Jesse <jbrandeburg@...udflare.com>;
> netdev@...r.kernel.org; kernel-team@...udflare.com; jbrandeb@...nel.org;
> leon@...nel.org; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>;
> Ertman, David M <david.m.ertman@...el.com>
> Subject: [Intel-wired-lan] [PATCH intel-net v2] ice: fix reservation of resources
> for RDMA when disabled
> 
> From: Jesse Brandeburg <jbrandeburg@...udflare.com>
> 
> If the CONFIG_INFINIBAND_IRDMA symbol is not enabled as a module or a
> built-in, then don't let the driver reserve resources for RDMA. The result of this
> change is a large savings in resources for older kernels, and a cleaner driver
> configuration for the IRDMA=n case for old and new kernels.
> 
> Implement this by avoiding enabling the RDMA capability when scanning
> hardware capabilities.
> 
> Note: Loading the out-of-tree irdma driver in connection to the in-kernel ice
> driver, is not supported, and should not be attempted, especially when
> disabling IRDMA in the kernel config.
> 
> Fixes: d25a0fc41c1f ("ice: Initialize RDMA support")
> Signed-off-by: Jesse Brandeburg <jbrandeburg@...udflare.com>
> Acked-by: Dave Ertman <david.m.ertman@...el.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> ---
> v2: resend with acks, add note about oot irdma (Leon), reword commit
> message
> v1: https://lore.kernel.org/netdev/20241114000105.703740-1-
> jbrandeb@...nel.org/
> ---
>  drivers/net/ethernet/intel/ice/ice_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c
> b/drivers/net/ethernet/intel/ice/ice_common.c
> index 7a2a2e8da8fa..1e801300310e 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -2271,7 +2271,8 @@ ice_parse_common_caps(struct ice_hw *hw, struct
> ice_hw_common_caps *caps,
>  			  caps->nvm_unified_update);
>  		break;
>  	case ICE_AQC_CAPS_RDMA:
> -		caps->rdma = (number == 1);
> +		if (IS_ENABLED(CONFIG_INFINIBAND_IRDMA))
> +			caps->rdma = (number == 1);
>  		ice_debug(hw, ICE_DBG_INIT, "%s: rdma = %d\n", prefix, caps-
> >rdma);
>  		break;
>  	case ICE_AQC_CAPS_MAX_MTU:
> --
> 2.43.0