netdev - RE: [PATCH v6 net-next 1/1] sched: Add dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR07MB79840984680ECC850D7C775EA3D52@PAXPR07MB7984.eurprd07.prod.outlook.com>
Date: Fri, 7 Mar 2025 08:30:36 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Cong Wang <xiyou.wangcong@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dave.taht@...il.com"
	<dave.taht@...il.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "horms@...nel.org"
	<horms@...nel.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"ij@...nel.org" <ij@...nel.org>, "ncardwell@...gle.com"
	<ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, g.white <g.white@...lelabs.com>,
	"ingemar.s.johansson@...csson.com" <ingemar.s.johansson@...csson.com>,
	"mirja.kuehlewind@...csson.com" <mirja.kuehlewind@...csson.com>,
	"cheshire@...le.com" <cheshire@...le.com>, "rs.ietf@....at" <rs.ietf@....at>,
	"Jason_Livingood@...cast.com" <Jason_Livingood@...cast.com>,
	"vidhi_goel@...le.com" <vidhi_goel@...le.com>, Olga Albisser
	<olga@...isser.org>, "Olivier Tilmans (Nokia)" <olivier.tilmans@...ia.com>,
	Henrik Steen <henrist@...rist.net>, Bob Briscoe <research@...briscoe.net>
Subject: RE: [PATCH v6 net-next 1/1] sched: Add dualpi2 qdisc

-----Original Message-----
From: Cong Wang <xiyou.wangcong@...il.com> 
Sent: Friday, March 7, 2025 12:36 AM
To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
Cc: netdev@...r.kernel.org; dave.taht@...il.com; pabeni@...hat.com; jhs@...atatu.com; kuba@...nel.org; stephen@...workplumber.org; jiri@...nulli.us; davem@...emloft.net; edumazet@...gle.com; horms@...nel.org; andrew+netdev@...n.ch; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white <g.white@...lelabs.com>; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel@...le.com; Olga Albisser <olga@...isser.org>; Olivier Tilmans (Nokia) <olivier.tilmans@...ia.com>; Henrik Steen <henrist@...rist.net>; Bob Briscoe <research@...briscoe.net>
Subject: Re: [PATCH v6 net-next 1/1] sched: Add dualpi2 qdisc


CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



> On Tue, Mar 04, 2025 at 04:15:03PM +0100, chia-yu.chang@...ia-bell-labs.com wrote:
> >  Documentation/netlink/specs/tc.yaml           |  140 +++
> >  include/linux/netdevice.h                     |    1 +
> >  include/uapi/linux/pkt_sched.h                |   38 +
> >  net/sched/Kconfig                             |   12 +
> >  net/sched/Makefile                            |    1 +
> >  net/sched/sch_dualpi2.c                       | 1081 +++++++++++++++++
> >  tools/testing/selftests/tc-testing/config     |    1 +
> >  .../tc-testing/tc-tests/qdiscs/dualpi2.json   |  149 +++
> >  tools/testing/selftests/tc-testing/tdc.sh     |    1 +
> 
> Please split this big patch into 3 patches:
> 1. Documentation, changes in Documentation/netlink/specs/tc.yaml
> 2. Selftest, changes under tools/testing/selftests/tc-testing/
> 3. The rest, which is the actual dualpi2 qdisc code
> 
> As Jakub mentioned, "mixing code changes and test changes in a single commit is discouraged."
> 
> Also, this would give reviewers a break between reviewing smaller patches.
> 
> Thanks!

Thanks for feedback.
I will provide v7 with three separated patches.

Brs,
Chia-Yu