netdev - Re: [PATCH net-next 1/3] ipv6: remove leftover ip6 cookie initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+zJOCutKxgsi0Ubi+Z3VyuR+fSdRuNHf=Tt_QqAQwUFg@mail.gmail.com>
Date: Fri, 7 Mar 2025 11:05:31 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, dsahern@...nel.org, horms@...nel.org, 
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 1/3] ipv6: remove leftover ip6 cookie initializer

On Fri, Mar 7, 2025 at 4:36 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> From: Willem de Bruijn <willemb@...gle.com>
>
> As of the blamed commit ipc6.dontfrag is always initialized at the
> start of udpv6_sendmsg, by ipcm6_init_sk, to either 0 or 1.
>
> Later checks against -1 are no longer needed and the branches are now
> dead code.
>
> The blamed commit had removed those branches. But I had overlooked
> this one case.
>
> UDP has both a lockless fast path and a slower path for corked
> requests. This branch remained in the fast path.
>
> Fixes: 096208592b09 ("ipv6: replace ipcm6_init calls with ipcm6_init_sk")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>