netdev - Re: [PATCH] net: liquidio: fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f2ba7b1-f923-4eb7-b90a-1cfa4d5c2f8d@aq0.de>
Date: Fri, 7 Mar 2025 15:59:58 +0100
From: Janik Haag <janik@....de>
To: Simon Horman <horms@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: liquidio: fix typo

Dear Simon,

I just submitted a v2 version of the patch, like you asked me to.
Thanks for the kind review and enjoy your weekend!

With kind regards,
Janik Haag

On 06.03.25 13:22, Simon Horman wrote:
> On Tue, Mar 04, 2025 at 07:16:52PM +0100, Janik Haag wrote:
>> Dear Linux maintainers, this is my first patch, hope everything is
>> correct.
>>
>> While reading through some pcie realted code I notice this small
>> spelling mistake of doorbell registers.
>> I added Dave in the TO field since they signed-off on by far the most
>> commits touching this file.
>>
>> With kind regards,
>> Janik Haag
>>
>> Signed-off-by: Janik Haag <janik@....de>
>> ---
>>   drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Hi Jainik,
>
> Thanks for your patch.
> It looks good, but I think we can make it better.
>
>
> Firstly, it's normal practice to describe your patch in the patch
> description, which is the bit above the scissors ("---") and add any notes
> below. Something like this.
>
>    Subject: net: liquidio: fix typo
>
>    Correct spelling of doorbells.
>
>    Found by inspection
>
>    Signed-of-by: ...
>    ---
>
>    Dear Linux Maintainers,
>
>    ...
>
> Secondly, as this is a non-bug-fix for Networking code it is for the
> net-next tree. It is preferable to note that net-next is the target
> tree in the subject, like this:
>
>    Subject: [PATCH net-next] net: liquidio: fix typo
>
> Last, I do see that codespell flags some other spelling errors in
> this file: "corressponding", "cant", and "Fomat".
> Perhaps they can be fixed at the same time?
>
>
> Could you consider posting a v2 patch, as a new thread, which
> addresses the above? The subject should be something like this:
>
>    Subject: [PATCH net-next v2] net: liquidio: fix typo
>
> As an aside, the b4 tool can be helpful for managing patch revisions.
>
> More information on Netdev process can be found here;
> https://docs.kernel.org/process/maintainer-netdev.html
>
> ...
>