netdev - Re: [PATCH bpf-next] bpf, sockmap: Simplify iteration on link removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLm9mvH=s_64RUcxOTMV7F_iAMN28PDVn8F9hw1kbeTAg@mail.gmail.com>
Date: Fri, 7 Mar 2025 10:36:07 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Michal Luczaj <mhal@...x.co>
Cc: John Fastabend <john.fastabend@...il.com>, Jakub Sitnicki <jakub@...udflare.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf, sockmap: Simplify iteration on link removal

On Fri, Mar 7, 2025 at 2:17 AM Michal Luczaj <mhal@...x.co> wrote:
>
> Since commit 75e072a390da ("bpf, sockmap: Fix update element with same"),
> using the _safe variant of list_for_each_entry() is unnecessary.

This is too subtle.
Somebody modifying this function next would have to keep
all these nuances in mind.
Let's keep it as-is.

pw-bot: cr