netdev - Re: [PATCH net-next v1 0/4] net: remove rtnl_lock from the callers of queue APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8u6cSJGzUGRFjkX@mini-arch>
Date: Fri, 7 Mar 2025 19:33:05 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	linux-kernel@...r.kernel.org, horms@...nel.org,
	donald.hunter@...il.com, michael.chan@...adcom.com,
	pavan.chebbi@...adcom.com, andrew+netdev@...n.ch,
	jdamato@...tly.com, xuanzhuo@...ux.alibaba.com,
	almasrymina@...gle.com, asml.silence@...il.com, dw@...idwei.uk
Subject: Re: [PATCH net-next v1 0/4] net: remove rtnl_lock from the callers
 of queue APIs

On 03/07, Jakub Kicinski wrote:
> On Fri,  7 Mar 2025 07:57:21 -0800 Stanislav Fomichev wrote:
> > All drivers that use queue management APIs already depend on the netdev
> > lock. Ultimately, we want to have most of the paths that work with
> > specific netdev to be rtnl_lock-free (ethtool mostly in particular).
> > Queue API currently has a much smaller API surface, so start with
> > rtnl_lock from it:
> > 
> > - add mutex to each dmabuf binding (to replace rtnl_lock)
> > - protect global net_devmem_dmabuf_bindings with a new (global) lock
> > - move netdev lock management to the callers of netdev_rx_queue_restart
> >   and drop rtnl_lock
> 
> One more note, looks like this silently conflicts with my:
> https://lore.kernel.org/all/20250307183006.2312761-1-kuba@kernel.org/
> 
> You need to add:
> 
> #include <net/netdev_lock.h>
> 
> to net/core/netdev_rx_queue.c, otherwise the series together break 
> the build.

Noted, thanks!