netdev - Re: [PATCH net] net: mana: Support holes in device list reply msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250307195029.1dc74f8e@kernel.org>
Date: Fri, 7 Mar 2025 19:50:29 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
 decui@...rosoft.com, stephen@...workplumber.org, kys@...rosoft.com,
 paulros@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com,
 davem@...emloft.net, wei.liu@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, leon@...nel.org, longli@...rosoft.com,
 ssengar@...ux.microsoft.com, linux-rdma@...r.kernel.org,
 daniel@...earbox.net, john.fastabend@...il.com, bpf@...r.kernel.org,
 ast@...nel.org, hawk@...nel.org, tglx@...utronix.de,
 shradhagupta@...ux.microsoft.com, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH net] net: mana: Support holes in device list reply msg

On Wed,  5 Mar 2025 13:46:21 -0800 Haiyang Zhang wrote:
> -	for (i = 0; i < max_num_devs; i++) {
> +	for (i = 0; i < GDMA_DEV_LIST_SIZE &&
> +		found_dev < resp.num_of_devs; i++) {

unfortunate mis-indent here, it blend with the code.
checkpatch is right that it should be aligned with opening bracket

>  		dev = resp.devs[i];
>  		dev_type = dev.type;
>  
> +		/* Skip empty devices */
> +		if (dev.as_uint32 == 0)
> +			continue;
> +
> +		found_dev++;
> +		dev_info(gc->dev, "Got devidx:%u, type:%u, instance:%u\n", i,
> +			 dev.type, dev.instance);

Are you sure you want to print this info message for each device,
each time it's probed? Seems pretty noisy. We generally recommend
printing about _unusual_ things.