netdev - Re: [PATCH net-next v1] dev: remove netdev_lock() and netdev_lock_ops() in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250308131813.4f8c8f0d@kernel.org>
Date: Sat, 8 Mar 2025 13:18:13 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kohei Enju <enjuk@...zon.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <bpf@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>, Sebastian
 Andrzej Siewior <bigeasy@...utronix.de>, "Ahmed Zaki"
 <ahmed.zaki@...el.com>, Stanislav Fomichev <sdf@...ichev.me>, "Alexander
 Lobakin" <aleksander.lobakin@...el.com>, Kohei Enju <kohei.enju@...il.com>
Subject: Re: [PATCH net-next v1] dev: remove netdev_lock() and
 netdev_lock_ops() in register_netdevice().

On Sun, 9 Mar 2025 05:37:18 +0900 Kohei Enju wrote:
> Both netdev_lock() and netdev_lock_ops() are called before
> list_netdevice() in register_netdevice().
> No other context can access the struct net_device, so we don't need these
> locks in this context.

Doesn't sysfs get registered earlier?
I'm afraid not being able to take the lock from the registration
path ties our hands too much. Maybe we need to make a more serious
attempt at letting the caller take the lock?