netdev - Re: [PATCH v3 net 7/8] net: devmem: do not WARN conditionally after netdev_rx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izNe4NBbTtordf04uE_+4fz9ut8rcgmNTuCiiZtDdy2M0Q@mail.gmail.com>
Date: Sun, 9 Mar 2025 14:45:30 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	edumazet@...gle.com, andrew+netdev@...n.ch, michael.chan@...adcom.com, 
	pavan.chebbi@...adcom.com, horms@...nel.org, shuah@...nel.org, 
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	asml.silence@...il.com, willemb@...gle.com, kaiyuanz@...gle.com, 
	skhawaja@...gle.com, sdf@...ichev.me, gospo@...adcom.com, 
	somnath.kotur@...adcom.com, dw@...idwei.uk, amritha.nambiar@...el.com, 
	xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH v3 net 7/8] net: devmem: do not WARN conditionally after netdev_rx_queue_restart()

On Sun, Mar 9, 2025 at 6:43 AM Taehee Yoo <ap420073@...il.com> wrote:
>
> When devmem socket is closed, netdev_rx_queue_restart() is called to
> reset queue by the net_devmem_unbind_dmabuf(). But callback may return
> -ENETDOWN if the interface is down because queues are already freed
> when the interface is down so queue reset is not needed.
> So, it should not warn if the return value is -ENETDOWN.
>
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>