netdev - Re: [PATCH 1/2] net: enc28j60: support getting irq number from gpio phandle in the device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b09bea7-2a61-4697-a9c1-6a42cf8570c4@lunn.ch>
Date: Sun, 9 Mar 2025 16:41:53 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Hanyuan Zhao <hanyuan-z@...com>
Cc: davem@...emloft.net, kuba@...nel.org, andrew+netdev@...n.ch,
	edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net: enc28j60: support getting irq number from gpio
 phandle in the device tree

On Sun, Mar 09, 2025 at 03:47:08PM +0800, Hanyuan Zhao wrote:
> This patch allows the kernel to automatically requests the pin, configures
> it as an input, and converts it to an IRQ number, according to a GPIO
> phandle specified in device tree. This simplifies the process by
> eliminating the need to manually define pinctrl and interrupt nodes.
> Additionally, it is necessary for platforms that do not support pin
> configuration and properties via the device tree.
> 
> Signed-off-by: Hanyuan Zhao <hanyuan-z@...com>
> ---
>  drivers/net/ethernet/microchip/enc28j60.c | 25 ++++++++++++++++++-----
>  1 file changed, 20 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60.c
> index d6c9491537e4..b3613e45c900 100644
> --- a/drivers/net/ethernet/microchip/enc28j60.c
> +++ b/drivers/net/ethernet/microchip/enc28j60.c
> @@ -24,6 +24,7 @@
>  #include <linux/skbuff.h>
>  #include <linux/delay.h>
>  #include <linux/spi/spi.h>
> +#include <linux/of_gpio.h>
>  
>  #include "enc28j60_hw.h"
>  
> @@ -1526,6 +1527,7 @@ static int enc28j60_probe(struct spi_device *spi)
>  	struct net_device *dev;
>  	struct enc28j60_net *priv;
>  	int ret = 0;
> +	unsigned long irq_flags = IRQF_ONESHOT;
>  
>  	if (netif_msg_drv(&debug))
>  		dev_info(&spi->dev, "Ethernet driver %s loaded\n", DRV_VERSION);
> @@ -1558,20 +1560,33 @@ static int enc28j60_probe(struct spi_device *spi)
>  		eth_hw_addr_random(dev);
>  	enc28j60_set_hw_macaddr(dev);
>  
> +	if (spi->irq > 0) {
> +		dev->irq = spi->irq;
> +	} else {
> +		/* Try loading device tree property irq-gpios */
> +		struct gpio_desc *irq_gpio_desc = devm_fwnode_gpiod_get_index(&spi->dev,
> +				of_fwnode_handle(spi->dev.of_node), "irq", 0, GPIOD_IN, NULL);
> +		if (IS_ERR(irq_gpio_desc)) {
> +			dev_err(&spi->dev, "unable to get a valid irq gpio\n");
> +			goto error_irq;
> +		}
> +		dev->irq = gpiod_to_irq(irq_gpio_desc);

My understanding is that you should not need most of this. The IRQ
core will handle converting a GPIO to an interrupt, if you just list
is as an interrupt source in the normal way.

> +		irq_flags |= IRQF_TRIGGER_FALLING;

You say:

> Additionally, it is necessary for platforms that do not support pin
> configuration and properties via the device tree.

Are you talking about ACPI?

	Andrew