| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202503102108.U88XuKx1-lkp@intel.com>
Date: Mon, 10 Mar 2025 21:52:13 +0800
From: kernel test robot <lkp@...el.com>
To: Eric Dumazet <edumazet@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, David Ahern <dsahern@...nel.org>,
Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
eric.dumazet@...il.com, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 3/4] inet: frags: change inet_frag_kill() to
defer refcount updates
Hi Eric,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/inet-frags-add-inet_frag_putn-helper/20250310-013501
base: net-next/main
patch link: https://lore.kernel.org/r/20250309173151.2863314-4-edumazet%40google.com
patch subject: [PATCH net-next 3/4] inet: frags: change inet_frag_kill() to defer refcount updates
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250310/202503102108.U88XuKx1-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250310/202503102108.U88XuKx1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503102108.U88XuKx1-lkp@intel.com/
All errors (new ones prefixed by >>):
net/ieee802154/6lowpan/reassembly.c: In function 'lowpan_frag_rcv':
>> net/ieee802154/6lowpan/reassembly.c:312:23: error: too few arguments to function 'lowpan_frag_queue'
312 | ret = lowpan_frag_queue(fq, skb, frag_type);
| ^~~~~~~~~~~~~~~~~
net/ieee802154/6lowpan/reassembly.c:86:12: note: declared here
86 | static int lowpan_frag_queue(struct lowpan_frag_queue *fq,
| ^~~~~~~~~~~~~~~~~
vim +/lowpan_frag_queue +312 net/ieee802154/6lowpan/reassembly.c
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 280
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 281 int lowpan_frag_rcv(struct sk_buff *skb, u8 frag_type)
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 282 {
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 283 struct lowpan_frag_queue *fq;
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 284 struct net *net = dev_net(skb->dev);
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 285 struct lowpan_802154_cb *cb = lowpan_802154_cb(skb);
f18fa5de5ba7f1d net/ieee802154/6lowpan/reassembly.c Alexander Aring 2018-04-20 286 struct ieee802154_hdr hdr = {};
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 287 int err;
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 288
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 289 if (ieee802154_hdr_peek_addrs(skb, &hdr) < 0)
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 290 goto err;
ae531b9475f62c5 net/ieee802154/reassembly.c Phoebe Buckheister 2014-03-14 291
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 292 err = lowpan_get_cb(skb, frag_type, cb);
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 293 if (err < 0)
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 294 goto err;
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 295
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 296 if (frag_type == LOWPAN_DISPATCH_FRAG1) {
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 297 err = lowpan_invoke_frag_rx_handlers(skb);
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 298 if (err == NET_RX_DROP)
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 299 goto err;
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 300 }
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 301
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 302 if (cb->d_size > IPV6_MIN_MTU) {
6697dabe27e0330 net/ieee802154/reassembly.c Martin Townsend 2014-08-19 303 net_warn_ratelimited("lowpan_frag_rcv: datagram size exceeds MTU\n");
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 304 goto err;
6697dabe27e0330 net/ieee802154/reassembly.c Martin Townsend 2014-08-19 305 }
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 306
72a5e6bb5120d64 net/ieee802154/6lowpan/reassembly.c Alexander Aring 2015-09-02 307 fq = fq_find(net, cb, &hdr.source, &hdr.dest);
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 308 if (fq != NULL) {
aec42e105cebf42 net/ieee802154/6lowpan/reassembly.c Eric Dumazet 2025-03-09 309 int ret, refs = 1;
4710d806fcb8251 net/ieee802154/reassembly.c Varka Bhadram 2014-07-02 310
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 311 spin_lock(&fq->q.lock);
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 @312 ret = lowpan_frag_queue(fq, skb, frag_type);
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 313 spin_unlock(&fq->q.lock);
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 314
aec42e105cebf42 net/ieee802154/6lowpan/reassembly.c Eric Dumazet 2025-03-09 315 inet_frag_putn(&fq->q, refs);
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 316 return ret;
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 317 }
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 318
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 319 err:
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 320 kfree_skb(skb);
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 321 return -1;
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 322 }
7240cdec60b136f net/ieee802154/reassembly.c Alexander Aring 2014-02-28 323
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists