netdev - Re: [PATCH v3 net 2/8] eth: bnxt: return fail if interface is down in bnxt_queue_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250310213023.05da8434@kernel.org>
Date: Mon, 10 Mar 2025 21:30:23 +0100
From: Jakub Kicinski <kuba@...nel.org>
To: Taehee Yoo <ap420073@...il.com>
Cc: Mina Almasry <almasrymina@...gle.com>, davem@...emloft.net,
 pabeni@...hat.com, edumazet@...gle.com, andrew+netdev@...n.ch,
 michael.chan@...adcom.com, pavan.chebbi@...adcom.com, horms@...nel.org,
 shuah@...nel.org, netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 asml.silence@...il.com, willemb@...gle.com, kaiyuanz@...gle.com,
 skhawaja@...gle.com, sdf@...ichev.me, gospo@...adcom.com,
 somnath.kotur@...adcom.com, dw@...idwei.uk, amritha.nambiar@...el.com,
 xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH v3 net 2/8] eth: bnxt: return fail if interface is down
 in bnxt_queue_mem_alloc()

On Mon, 10 Mar 2025 11:10:42 +0900 Taehee Yoo wrote:
> > Although I wonder if you wanna return -ENETDOWN from other queue API
> > ops, if your driver doesn't handle them.  
> 
> Okay, I will add -ENETDOWN return to the other queue API in the next
> version.

I prefer the current version. If queues can't be allocated while down,
how can free be called..