netdev - Re: [PATCH net-next] eth: fbnic: fix memory corruption in fbnic_tlv_attr_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174163924349.3688527.16911619738250606292.git-patchwork-notify@kernel.org>
Date: Mon, 10 Mar 2025 20:40:43 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: lee@...ger.us, alexanderduyck@...com, kuba@...nel.org,
 kernel-team@...a.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] eth: fbnic: fix memory corruption in
 fbnic_tlv_attr_get_string()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 7 Mar 2025 12:28:48 +0300 you wrote:
> This code is trying to ensure that the last byte of the buffer is a NUL
> terminator.  However, the problem is that attr->value[] is an array of
> __le32, not char, so it zeroes out 4 bytes way beyond the end of the
> buffer.  Cast the buffer to char to address this.
> 
> Fixes: e5cf5107c9e4 ("eth: fbnic: Update fbnic_tlv_attr_get_string() to work like nla_strscpy()")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> [...]

Here is the summary with links:
  - [net-next] eth: fbnic: fix memory corruption in fbnic_tlv_attr_get_string()
    https://git.kernel.org/netdev/net-next/c/991a1b09920b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html