netdev - Re: [PATCH iproute2-next v2] color: default to dark color theme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250310141216.5cdfd133@hermes.local>
Date: Mon, 10 Mar 2025 14:12:16 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Matteo Croce <technoboy85@...il.com>
Cc: netdev@...r.kernel.org, Phil Sutter <phil@....cc>, Matteo Croce
 <teknoraver@...a.com>
Subject: Re: [PATCH iproute2-next v2] color: default to dark color theme

On Mon, 10 Mar 2025 21:36:09 +0100
Matteo Croce <technoboy85@...il.com> wrote:

> From: Matteo Croce <teknoraver@...a.com>
> 
> The majority of Linux terminals are using a dark background.
> iproute2 tries to detect the color theme via the `COLORFGBG` environment
> variable, and defaults to light background if not set.
>

This is not true. The default gnome terminal color palette is not dark.

> Change the default behaviour to dark background, and while at it change
> the current logic which assumes that the color code is a single digit.
> 
> Signed-off-by: Matteo Croce <teknoraver@...a.com>

The code was added to follow the conventions of other Linux packages.
Probably best to do something smarter (like util-linux) or more exactly
follow what systemd or vim are doing.