netdev - Re: [PATCH net-next v4 2/2] net: hsr: Add KUnit test for PRP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAGp9GRaBiaFjRDWHi2J2_O9Om789M_CTr9Cko7oBh5YpJzg_HQ@mail.gmail.com>
Date: Mon, 10 Mar 2025 08:42:06 +0200
From: Jaakko Karrenpalo <jkarrenpalo@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Lukasz Majewski <lukma@...x.de>, 
	MD Danish Anwar <danishanwar@...com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, 
	Jaakko Karrenpalo <jaakko.karrenpalo@...abb.com>
Subject: Re: [PATCH net-next v4 2/2] net: hsr: Add KUnit test for PRP

On Fri, Mar 7, 2025 at 3:04 PM Not Teknology <jkarrenpalo@...il.com> wrote:
>
>
>
> On Fri, Mar 7, 2025, 03:52 Jakub Kicinski <kuba@...nel.org> wrote:
>>
>> On Tue,  4 Mar 2025 12:40:30 +0200 Jaakko Karrenpalo wrote:
>> > Add unit tests for the PRP duplicate detection
>>
>> The patch appears unable to survive an allmodconfig build:
>> ERROR: modpost: "prp_register_frame_out" [net/hsr/prp_dup_discard_test.ko] undefined!
>>
>> Guessing that it ends up built in and the function is in a module?
>> Maybe a depends on ?
>> --
>> pw-bot: cr
>
>
> I used the wrong CONFIG_ define with IS_MODULE(). It should be the one without _MODULE at the end. Not that familiar with those.
>
> I must have messed up something when running the build locally, because I did manage to compile somehow.
>
> /Jaakko

And sorry about the previous mail not being plain text, gmail decided
to send it in html-mode

/Jaakko