netdev - Re: [PATCH rdma-next 0/5] Add optional-counters binding support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250310075415.GA505188@unreal>
Date: Mon, 10 Mar 2025 09:54:15 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Patrisious Haddad <phaddad@...dia.com>
Cc: Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
	Mark Bloch <mbloch@...dia.com>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH rdma-next 0/5] Add optional-counters binding support

On Sat, Mar 08, 2025 at 02:31:33PM -0500, Leon Romanovsky wrote:
> 
> On Tue, 04 Mar 2025 16:15:24 +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@...dia.com>
> > 
> > From Patrisious,
> > 
> > Add optional-counters binding support together with new packets/bytes
> > counters. Previously optional-counters were on a per link basis, this
> > series allows users to bind optional-counters to a specific counter,
> > which allows tracking optional-counter over a specific QP group.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/5] RDMA/mlx5: Add optional counters for RDMA_TX/RX_packets/bytes
>       https://git.kernel.org/rdma/rdma/c/30c77a88e3ffe9
> [2/5] RDMA/core: Create and destroy rdma_counter using rdma_zalloc_drv_obj()
>       https://git.kernel.org/rdma/rdma/c/3644e21c005fcf
> [3/5] RDMA/core: Add support to optional-counters binding configuration
>       https://git.kernel.org/rdma/rdma/c/df5f4ff6319a6f
> [4/5] RDMA/core: Pass port to counter bind/unbind operations
>       https://git.kernel.org/rdma/rdma/c/d73531da19eb56
> [5/5] RDMA/mlx5: Support optional-counters binding for QPs
>       https://git.kernel.org/rdma/rdma/c/7bcd537adb21b5a

Unfortunately, but I need to drop this series from our wip branches.
The reason to it is patch #5 which has layer violation of bringing
RDMA counters logic into flow steering code.

As such it caused to multiple kbuild errors, because fs.c is available
only when CONFIG_INFINIBAND_USER_ACCESS is set, while counters and
rdmatool (bind/unbind logic) is not limited to user space verbs only.

This series needs to be fixed:
1. RDMA counters logic need to stay in counter.c
2. Optional counters need to work on all type of QPs.

Thanks

> 
> Best regards,
> -- 
> Leon Romanovsky <leon@...nel.org>
>