netdev - Re: [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink for improved PHY and MAC management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z863zsYNM8hkfB19@pengutronix.de>
Date: Mon, 10 Mar 2025 10:58:38 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Thangaraj.S@...rochip.com
Cc: andrew+netdev@...n.ch, rmk+kernel@...linux.org.uk, davem@...emloft.net,
	Rengarajan.S@...rochip.com, Woojung.Huh@...rochip.com,
	pabeni@...hat.com, edumazet@...gle.com, kuba@...nel.org,
	phil@...pberrypi.org, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink
 for improved PHY and MAC management

Hi Thangaraj,

On Mon, Mar 10, 2025 at 09:29:45AM +0000, Thangaraj.S@...rochip.com wrote:
> > -       mii_adv_to_linkmode_adv_t(fc, mii_adv);
> > -       linkmode_or(phydev->advertising, fc, phydev->advertising);
> > +       phy_suspend(phydev);
> > 
> 
> Why phy_suspend called in the init? Is there any specific reason?

In my tests with EVB-LAN7801-EDS, the attached PHY stayed UP in initial
state. phy_suspend() solved this issue. But I need to retest it with all
latest changes.

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |