netdev - Re: [PATCH net-next] net: bcmgenet: use genphy_c45_eee_is_active directly, instead of phy_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a99a33c6-d539-4be3-8a8a-3be1753eefb8@broadcom.com>
Date: Tue, 11 Mar 2025 06:10:12 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: Doug Berger <opendmb@...il.com>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 David Miller <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH net-next] net: bcmgenet: use genphy_c45_eee_is_active
 directly, instead of phy_init_eee



On 3/11/2025 5:58 AM, Andrew Lunn wrote:
> On Tue, Mar 11, 2025 at 07:43:10AM +0100, Heiner Kallweit wrote:
>> Use genphy_c45_eee_is_active directly instead of phy_init_eee,
>> this prepares for removing phy_init_eee. With the second
>> argument being Null, phy_init_eee doesn't initialize anything.
> 
> bcmgenet_set_eee() is an example where EEE is done wrong. EEE is
> negotiated, so you cannot configure the MAC until autoneg has
> completed. So phy_init_eee() should only be called from the adjust
> link callback. In this driver, it is only being called in the ethtool
> .set_ee op, which is wrong. So all this patch does is replace one
 > broken things with another broken thing.
> 
> Please consider my old patch:
> 
> https://github.com/lunn/linux/commit/c226f4dbe9aa9c51c1308561aba64c722dab04fb
> 
> It will need updating, but this is how i think this should be solved.

Your old patch was tested and had regressions, and I did not see a 
follow up to it. The Raspberry Pi 4 systems use this Ethernet controller 
and the PHY does have EEE available, so it should not be too hard to get 
  a platform to test on.
-- 
Florian