netdev - Re: [PATCH net-next 0/7] net: xdp: Add missing metadata support for some xdp drvs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9BYNBaAGZbtbfa4@localhost.localdomain>
Date: Tue, 11 Mar 2025 16:35:16 +0100
From: Michal Kubiak <michal.kubiak@...el.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
CC: Marcin Wojtas <marcin.s.wojtas@...il.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, "John
 Fastabend" <john.fastabend@...il.com>, Russell King <linux@...linux.org.uk>,
	Ilias Apalodimas <ilias.apalodimas@...aro.org>, Masahisa Kojima
	<kojima.masahisa@...ionext.com>, Sunil Goutham <sgoutham@...vell.com>,
	"Geetha sowjanya" <gakula@...vell.com>, Subbaraya Sundeep
	<sbhatta@...vell.com>, hariprasad <hkelam@...vell.com>, Bharat Bhushan
	<bbhushan2@...vell.com>, Felix Fietkau <nbd@....name>, Sean Wang
	<sean.wang@...iatek.com>, "Matthias Brugger" <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, "K. Y.
 Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei
 Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, Siddharth
 Vadapalli <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>,
	<netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>,
	<linux-hyperv@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH net-next 0/7] net: xdp: Add missing metadata support for
 some xdp drvs

On Tue, Mar 11, 2025 at 01:18:32PM +0100, Lorenzo Bianconi wrote:
> Introduce missing metadata support for some xdp drivers setting metadata
> size building the skb from xdp_buff.
> Please note most of the drivers are just compile tested.
> 
> ---
> Lorenzo Bianconi (7):
>       net: mvneta: Add metadata support for xdp mode
>       net: mvpp2: Add metadata support for xdp mode
>       net: netsec: Add metadata support for xdp mode
>       net: octeontx2: Add metadata support for xdp mode
>       net: ethernet: mediatek: Add metadata support for xdp mode
>       net: mana: Add metadata support for xdp mode
>       net: ti: cpsw: Add metadata support for xdp mode
> 
>  drivers/net/ethernet/marvell/mvneta.c                  |  5 ++++-
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c        |  8 ++++++--
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 13 +++++++++----
>  drivers/net/ethernet/mediatek/mtk_eth_soc.c            |  7 +++++--
>  drivers/net/ethernet/microsoft/mana/mana_bpf.c         |  2 +-
>  drivers/net/ethernet/microsoft/mana/mana_en.c          |  4 ++++
>  drivers/net/ethernet/socionext/netsec.c                |  7 +++++--
>  drivers/net/ethernet/ti/cpsw.c                         |  6 +++++-
>  drivers/net/ethernet/ti/cpsw_new.c                     |  6 +++++-
>  9 files changed, 44 insertions(+), 14 deletions(-)
> ---
> base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe
> change-id: 20250310-mvneta-xdp-meta-3e0da8ef4498
> 
> Best regards,
> -- 
> Lorenzo Bianconi <lorenzo@...nel.org>
> 
> 

As far as I checked, all modified drivers use the Page Pool and set the XDP
headroom. So, a necessary space for metadata seems to be assured for all
of the drivers.
In summary, the series looks OK.

Thanks,
Michal

For the series:
Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>