netdev - Re: [PATCH net v3] net: ethernet: ti: am65-cpsw: Fix NAPI registration sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f6b99966ff7ad119d087e65f0f58e5b1411066f.camel@siemens.com>
Date: Tue, 11 Mar 2025 18:49:38 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "s-vadapalli@...com"
	<s-vadapalli@...com>, "davem@...emloft.net" <davem@...emloft.net>,
	"dan.carpenter@...aro.org" <dan.carpenter@...aro.org>, "jpanis@...libre.com"
	<jpanis@...libre.com>, "npitre@...libre.com" <npitre@...libre.com>,
	"c-vankar@...com" <c-vankar@...com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "rogerq@...nel.org" <rogerq@...nel.org>,
	"kuba@...nel.org" <kuba@...nel.org>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "vigneshr@...com" <vigneshr@...com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "srk@...com"
	<srk@...com>
Subject: Re: [PATCH net v3] net: ethernet: ti: am65-cpsw: Fix NAPI
 registration sequence

Thanks Siddharth for reworking the patch!

On Tue, 2025-03-11 at 21:12 +0530, Siddharth Vadapalli wrote:
> From: Vignesh Raghavendra <vigneshr@...com>
> 
> Registering the interrupts for TX or RX DMA Channels prior to registering
> their respective NAPI callbacks can result in a NULL pointer dereference.
> This is seen in practice as a random occurrence since it depends on the
> randomness associated with the generation of traffic by Linux and the
> reception of traffic from the wire.
> 
> Fixes: 681eb2beb3ef ("net: ethernet: ti: am65-cpsw: ensure proper channel cleanup in error path")
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> Co-developed-by: Siddharth Vadapalli <s-vadapalli@...com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>

LGTM,
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 32 +++++++++++++-----------
>  1 file changed, 18 insertions(+), 14 deletions(-)

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com