netdev - RE: [Intel-wired-lan] [PATCH iwl-next v3 4/4] ixgbe: add E610 .set_phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH8PR11MB796540293289014CE6B0871BF7D12@PH8PR11MB7965.namprd11.prod.outlook.com>
Date: Tue, 11 Mar 2025 07:39:28 +0000
From: "R, Bharath" <bharath.r@...el.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "andrew@...n.ch" <andrew@...n.ch>,
	"pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v3 4/4] ixgbe: add E610
 .set_phys_id() callback implementation

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jedrzej Jagielski
> Sent: Monday, March 3, 2025 5:37 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> netdev@...r.kernel.org; andrew@...n.ch; pmenzel@...gen.mpg.de;
> Jagielski, Jedrzej <jedrzej.jagielski@...el.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@...el.com>; Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v3 4/4] ixgbe: add E610
> .set_phys_id() callback implementation
> 
> Legacy implementation of .set_phys_id() ethtool callback is not applicable for
> E610 device.
> 
> Add new implementation which uses 0x06E9 command by calling
> ixgbe_aci_set_port_id_led().
> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
> v3: move the #defines related to ixgbe_aci_cmd_set_port_id_led out of the
> struct definition
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 29 +++++++++++++++++++
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h |  1 +
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  | 22 +++++++++++++-
>  .../ethernet/intel/ixgbe/ixgbe_type_e610.h    | 14 +++++++++
>  4 files changed, 65 insertions(+), 1 deletion(-)
> 

Tested-by: Bharath R <bharath.r@...el.com>