netdev - Re: [net v1] devlink: fix xa_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8//h7IT3cf01bxB@mev-dev.igk.intel.com>
Date: Tue, 11 Mar 2025 10:16:55 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Pierre Riteau <pierre@...ckhpc.com>
Cc: Paolo Abeni <pabeni@...hat.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
	jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, horms@...nel.org,
	Dan Carpenter <error27@...il.com>
Subject: Re: [net v1] devlink: fix xa_alloc_cyclic error handling

On Mon, Mar 10, 2025 at 12:42:13PM +0100, Pierre Riteau wrote:
> On Tue, 18 Feb 2025 at 12:56, Paolo Abeni <pabeni@...hat.com> wrote:
> >
> >
> >
> > On 2/14/25 2:58 PM, Michal Swiatkowski wrote:
> > > On Fri, Feb 14, 2025 at 02:44:49PM +0100, Andrew Lunn wrote:
> > >> On Fri, Feb 14, 2025 at 02:24:53PM +0100, Michal Swiatkowski wrote:
> > >>> Pierre Riteau <pierre@...ckhpc.com> found suspicious handling an error
> > >>> from xa_alloc_cyclic() in scheduler code [1]. The same is done in
> > >>> devlink_rel_alloc().
> > >>
> > >> If the same bug exists twice it might exist more times. Did you find
> > >> this instance by searching the whole tree? Or just networking?
> > >>
> > >> This is also something which would be good to have the static
> > >> analysers check for. I wounder if smatch can check this?
> > >>
> > >>      Andrew
> > >>
> > >
> > > You are right, I checked only net folder and there are two usage like
> > > that in drivers. I will send v2 with wider fixing, thanks.
> >
> > While at that, please add the suitable fixes tag(s).
> >
> > Thanks,
> >
> > Paolo
> 
> Hello,
> 
> I haven't seen a v2 patch from Michal Swiatkowski. Would it be okay to
> at least merge this net/devlink/core.c fix for inclusion in 6.14? I
> can send a revised patch adding the Fixes tag. Driver fixes could be
> addressed separately.
> 

Sorry that I didn't send v2, but I have seen that Dan wrote to Jiri
about this code and also found more places to fix. I assumed that he
will send a fix for all cases that he found.

Dan, do you plan to send it or I should send v2?

Thanks,
Michal

> Thanks,
> Pierre