| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202503121005.iGEV5eau-lkp@intel.com>
Date: Wed, 12 Mar 2025 11:16:12 +0800
From: kernel test robot <lkp@...el.com>
To: Paul Greenwalt <paul.greenwalt@...el.com>,
intel-wired-lan@...ts.osuosl.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
netdev@...r.kernel.org, anthony.l.nguyen@...el.com,
Paul Greenwalt <paul.greenwalt@...el.com>,
Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
Alice Michael <alice.michael@...el.com>
Subject: Re: [PATCH iwl-next v2] ice: add E830 Earliest TxTime First Offload
support
Hi Paul,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-next-queue/dev-queue]
url: https://github.com/intel-lab-lkp/linux/commits/Paul-Greenwalt/ice-add-E830-Earliest-TxTime-First-Offload-support/20250312-051400
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link: https://lore.kernel.org/r/20250311132327.76804-1-paul.greenwalt%40intel.com
patch subject: [PATCH iwl-next v2] ice: add E830 Earliest TxTime First Offload support
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250312/202503121005.iGEV5eau-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250312/202503121005.iGEV5eau-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503121005.iGEV5eau-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_vsi_cfg_txq':
>> drivers/net/ethernet/intel/ice/ice_base.c:1023:46: warning: passing argument 1 of 'ice_calc_txq_handle' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1023 | ring->q_handle = ice_calc_txq_handle(vsi, ring, tc);
| ^~~
drivers/net/ethernet/intel/ice/ice_base.c:245:48: note: expected 'struct ice_vsi *' but argument is of type 'const struct ice_vsi *'
245 | static u16 ice_calc_txq_handle(struct ice_vsi *vsi, struct ice_tx_ring *ring, u8 tc)
| ~~~~~~~~~~~~~~~~^~~
vim +1023 drivers/net/ethernet/intel/ice/ice_base.c
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 974
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 975 /**
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 976 * ice_vsi_cfg_txq - Configure single Tx queue
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 977 * @vsi: the VSI that queue belongs to
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 978 * @ring: Tx ring to be configured
51900dfcf194b39 Paul Greenwalt 2025-03-11 979 * @tstamp_ring: time stamp ring to be configured
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 980 * @qg_buf: queue group buffer
51900dfcf194b39 Paul Greenwalt 2025-03-11 981 * @txtime_qg_buf: Tx Time queue group buffer
51900dfcf194b39 Paul Greenwalt 2025-03-11 982 *
51900dfcf194b39 Paul Greenwalt 2025-03-11 983 * Return: 0 on success and a negative value on error.
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 984 */
a292ba981324ec7 Maciej Fijalkowski 2024-01-23 985 static int
51900dfcf194b39 Paul Greenwalt 2025-03-11 986 ice_vsi_cfg_txq(const struct ice_vsi *vsi, struct ice_tx_ring *ring,
51900dfcf194b39 Paul Greenwalt 2025-03-11 987 struct ice_tx_ring *tstamp_ring,
51900dfcf194b39 Paul Greenwalt 2025-03-11 988 struct ice_aqc_add_tx_qgrp *qg_buf,
51900dfcf194b39 Paul Greenwalt 2025-03-11 989 struct ice_aqc_set_txtime_qgrp *txtime_qg_buf)
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 990 {
66486d8943bac36 Bruce Allan 2020-06-29 991 u8 buf_len = struct_size(qg_buf, txqs, 1);
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 992 struct ice_tlan_ctx tlan_ctx = { 0 };
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 993 struct ice_aqc_add_txqs_perq *txq;
0754d65bd4be5bb Kiran Patil 2021-10-15 994 struct ice_channel *ch = ring->ch;
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 995 struct ice_pf *pf = vsi->back;
7e34786a74e1403 Bruce Allan 2020-05-15 996 struct ice_hw *hw = &pf->hw;
5e24d5984c805c6 Tony Nguyen 2021-10-07 997 int status;
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 998 u16 pf_q;
e75d1b2c3731999 Maciej Fijalkowski 2019-10-24 999 u8 tc;
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1000
634da4c118434cf Benita Bose 2021-03-02 1001 /* Configure XPS */
634da4c118434cf Benita Bose 2021-03-02 1002 ice_cfg_xps_tx_ring(ring);
634da4c118434cf Benita Bose 2021-03-02 1003
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1004 pf_q = ring->reg_idx;
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1005 ice_setup_tx_ctx(ring, &tlan_ctx, pf_q);
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1006 /* copy context contents into the qg_buf */
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1007 qg_buf->txqs[0].txq_id = cpu_to_le16(pf_q);
dc4305be467a6f8 Jacob Keller 2024-12-10 1008 ice_pack_txq_ctx(&tlan_ctx, &qg_buf->txqs[0].txq_ctx);
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1009
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1010 /* init queue specific tail reg. It is referred as
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1011 * transmit comm scheduler queue doorbell.
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1012 */
7e34786a74e1403 Bruce Allan 2020-05-15 1013 ring->tail = hw->hw_addr + QTX_COMM_DBELL(pf_q);
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1014
e75d1b2c3731999 Maciej Fijalkowski 2019-10-24 1015 if (IS_ENABLED(CONFIG_DCB))
e75d1b2c3731999 Maciej Fijalkowski 2019-10-24 1016 tc = ring->dcb_tc;
e75d1b2c3731999 Maciej Fijalkowski 2019-10-24 1017 else
e75d1b2c3731999 Maciej Fijalkowski 2019-10-24 1018 tc = 0;
e75d1b2c3731999 Maciej Fijalkowski 2019-10-24 1019
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1020 /* Add unique software queue handle of the Tx queue per
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1021 * TC into the VSI Tx ring
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1022 */
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19 @1023 ring->q_handle = ice_calc_txq_handle(vsi, ring, tc);
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1024
0754d65bd4be5bb Kiran Patil 2021-10-15 1025 if (ch)
0754d65bd4be5bb Kiran Patil 2021-10-15 1026 status = ice_ena_vsi_txq(vsi->port_info, ch->ch_vsi->idx, 0,
0754d65bd4be5bb Kiran Patil 2021-10-15 1027 ring->q_handle, 1, qg_buf, buf_len,
0754d65bd4be5bb Kiran Patil 2021-10-15 1028 NULL);
0754d65bd4be5bb Kiran Patil 2021-10-15 1029 else
0754d65bd4be5bb Kiran Patil 2021-10-15 1030 status = ice_ena_vsi_txq(vsi->port_info, vsi->idx, tc,
0754d65bd4be5bb Kiran Patil 2021-10-15 1031 ring->q_handle, 1, qg_buf, buf_len,
0754d65bd4be5bb Kiran Patil 2021-10-15 1032 NULL);
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1033 if (status) {
5f87ec4861aa1b8 Tony Nguyen 2021-10-07 1034 dev_err(ice_pf_to_dev(pf), "Failed to set LAN Tx queue context, error: %d\n",
5f87ec4861aa1b8 Tony Nguyen 2021-10-07 1035 status);
c14846914ed6b57 Tony Nguyen 2021-10-07 1036 return status;
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1037 }
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1038
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1039 /* Add Tx Queue TEID into the VSI Tx ring from the
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1040 * response. This will complete configuring and
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1041 * enabling the queue.
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1042 */
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1043 txq = &qg_buf->txqs[0];
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1044 if (pf_q == le16_to_cpu(txq->txq_id))
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1045 ring->txq_teid = le32_to_cpu(txq->q_teid);
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1046
51900dfcf194b39 Paul Greenwalt 2025-03-11 1047 if (tstamp_ring) {
51900dfcf194b39 Paul Greenwalt 2025-03-11 1048 u8 txtime_buf_len = struct_size(txtime_qg_buf, txtimeqs, 1);
51900dfcf194b39 Paul Greenwalt 2025-03-11 1049 struct ice_txtime_ctx txtime_ctx = {};
51900dfcf194b39 Paul Greenwalt 2025-03-11 1050
51900dfcf194b39 Paul Greenwalt 2025-03-11 1051 ice_setup_txtime_ctx(tstamp_ring, &txtime_ctx,
51900dfcf194b39 Paul Greenwalt 2025-03-11 1052 !!(ring->flags & ICE_TX_FLAGS_TXTIME));
51900dfcf194b39 Paul Greenwalt 2025-03-11 1053 ice_pack_txtime_ctx(&txtime_ctx,
51900dfcf194b39 Paul Greenwalt 2025-03-11 1054 &txtime_qg_buf->txtimeqs[0].txtime_ctx);
51900dfcf194b39 Paul Greenwalt 2025-03-11 1055
51900dfcf194b39 Paul Greenwalt 2025-03-11 1056 tstamp_ring->tail =
51900dfcf194b39 Paul Greenwalt 2025-03-11 1057 hw->hw_addr + E830_GLQTX_TXTIME_DBELL_LSB(pf_q);
51900dfcf194b39 Paul Greenwalt 2025-03-11 1058
51900dfcf194b39 Paul Greenwalt 2025-03-11 1059 status = ice_aq_set_txtimeq(hw, pf_q, 1, txtime_qg_buf,
51900dfcf194b39 Paul Greenwalt 2025-03-11 1060 txtime_buf_len, NULL);
51900dfcf194b39 Paul Greenwalt 2025-03-11 1061 if (status) {
51900dfcf194b39 Paul Greenwalt 2025-03-11 1062 dev_err(ice_pf_to_dev(pf), "Failed to set Tx Time queue context, error: %d\n",
51900dfcf194b39 Paul Greenwalt 2025-03-11 1063 status);
51900dfcf194b39 Paul Greenwalt 2025-03-11 1064 return status;
51900dfcf194b39 Paul Greenwalt 2025-03-11 1065 }
51900dfcf194b39 Paul Greenwalt 2025-03-11 1066 }
51900dfcf194b39 Paul Greenwalt 2025-03-11 1067
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1068 return 0;
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1069 }
eff380aaffedb27 Anirudh Venkataramanan 2019-10-24 1070
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists