netdev - RE: [PATCH iwl-next v2] i40e: fix MMIO write access to an invalid page in i40e_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB586660B18AD7AD64E53746EFE5D02@SJ0PR11MB5866.namprd11.prod.outlook.com>
Date: Wed, 12 Mar 2025 13:22:43 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, Kyungwook Boo
	<bookyungwook@...il.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>
Subject: RE: [PATCH iwl-next v2] i40e: fix MMIO write access to an invalid
 page in i40e_clear_hw



> -----Original Message-----
> From: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Sent: Tuesday, March 11, 2025 10:15 AM
> To: Kyungwook Boo <bookyungwook@...il.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Loktionov,
> Aleksandr <aleksandr.loktionov@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Subject: Re: [PATCH iwl-next v2] i40e: fix MMIO write access to an invalid page
> in i40e_clear_hw
> 
> On 3/11/25 06:16, Kyungwook Boo wrote:
> > When the device sends a specific input, an integer underflow can
> > occur, leading to MMIO write access to an invalid page.
> >
> > Prevent the integer underflow by changing the type of related variables.
> >
> > Signed-off-by: Kyungwook Boo <bookyungwook@...il.com>
> > Link:
> > https://lore.kernel.org/lkml/ffc91764-1142-4ba2-91b6-
> 8c773f6f7095@...i
> > l.com/T/
> > ---
> > Changes in v2:
> > - Formatting properly
> > - Fix variable shadowing
> > - Link to v1:
> > https://lore.kernel.org/netdev/55acc5dc-8d5a-45bc-a59c-
> 9304071e4579@gm
> > ail.com/
> > ---
> >   drivers/net/ethernet/intel/i40e/i40e_common.c | 7 ++++---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c
> > b/drivers/net/ethernet/intel/i40e/i40e_common.c
> > index 370b4bddee44..b11c35e307ca 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_common.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
> > @@ -817,10 +817,11 @@ int i40e_pf_reset(struct i40e_hw *hw)
> >   void i40e_clear_hw(struct i40e_hw *hw)
> >   {
> >   	u32 num_queues, base_queue;
> > -	u32 num_pf_int;
> > -	u32 num_vf_int;
> > +	s32 num_pf_int;
> > +	s32 num_vf_int;
> >   	u32 num_vfs;
> > -	u32 i, j;
> > +	s32 i;
> > +	u32 j;
> >   	u32 val;
> >   	u32 eol = 0x7ff;
> 
> thank you for localizing the improvement, now the code is more robust,
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> >
> > ---
> > base-commit: 4d872d51bc9d7b899c1f61534e3dbde72613f627
> >
> > Best regards,
> > Kyungwook Boo
> >