netdev - Re: [PATCH net] net: switchdev: Convert blocking notification chain to a raw one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9HJUx4mnGKLBZMn@shredder>
Date: Wed, 12 Mar 2025 19:50:11 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: amcohen@...dia.com, horms@...nel.org, davem@...emloft.net,
	edumazet@...gle.com, ivecera@...hat.com, jiri@...nulli.us,
	kuba@...nel.org, netdev@...r.kernel.org, olteanv@...il.com,
	pabeni@...hat.com, petrm@...dia.com, tobias@...dekranz.com
Subject: Re: [PATCH net] net: switchdev: Convert blocking notification chain
 to a raw one

On Tue, Mar 11, 2025 at 01:12:50AM -0700, Kuniyuki Iwashima wrote:
> From: Simon Horman <horms@...nel.org>
> > As you may be aware there is quite some activity to reduce the reliance on
> > RTNL. However, as the events in question are already protected by RTNL
> > I think the approach you have taken here is entirely reasonable.
> 
> It would be appreicated if Amit you can post a follow-up patch against
> net-next.git to convert the rtnl_lock() to another lock or rtnl_net_lock().

We're obviously aware of the RTNL related work and we thought about
making these notification chains (atomic and blocking) per-netns, but
it's not something that can be submitted as a fix.

I will look into it, but there are some listeners that I'm not sure how
to convert. I can register them with "&init_net" for RFC. Hopefully the
relevant maintainers will be able to help with that.

Note that we will need to keep ASSERT_RTNL() in
call_switchdev_blocking_notifiers() until all the callers are converted
to per-netns RTNL.