netdev - Re: [PATCH iproute2-next] tc: nat: Fix mask calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: 
 <174180423251.890466.11023139141419811729.git-patchwork-notify@kernel.org>
Date: Wed, 12 Mar 2025 18:30:32 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Torben Nielsen <t8927095@...il.com>
Cc: netdev@...r.kernel.org, torben.nielsen@...vas.dk
Subject: Re: [PATCH iproute2-next] tc: nat: Fix mask calculation

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@...workplumber.org>:

On Thu,  6 Mar 2025 12:25:19 +0100 you wrote:
> In parse_nat_args the network mask is calculated as
> 
>         sel->mask = htonl(~0u << (32 - addr.bitlen));
> 
> According to  ISO/IEC 9899:TC3 6.5.7 Bitwise shift operators:
> The integer promotions are performed on each of the operands.
> The type of the result is that of the promoted left operand.
> If the value of the right operand is negative or is greater
> than or equal to the width of the promoted left operand,
> the behavior is undefined
> 
> [...]

Here is the summary with links:
  - [iproute2-next] tc: nat: Fix mask calculation
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=667817b4c349

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html