netdev - Re: [PATCH net-next] net: revert to lockless TC_SETUP_BLOCK and TC_SETUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174181083101.918963.13075833361323469787.git-patchwork-notify@kernel.org>
Date: Wed, 12 Mar 2025 20:20:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, horms@...nel.org, corbet@....net,
 andrew+netdev@...n.ch, pablo@...filter.org, kadlec@...filter.org
Subject: Re: [PATCH net-next] net: revert to lockless TC_SETUP_BLOCK and
 TC_SETUP_FT

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri,  7 Mar 2025 20:47:26 -0800 you wrote:
> There is a couple of places from which we can arrive to ndo_setup_tc
> with TC_SETUP_BLOCK/TC_SETUP_FT:
> - netlink
> - netlink notifier
> - netdev notifier
> 
> Locking netdev too deep in this call chain seems to be problematic
> (especially assuming some/all of the call_netdevice_notifiers
> NETDEV_UNREGISTER) might soon be running with the instance lock).
> Revert to lockless ndo_setup_tc for TC_SETUP_BLOCK/TC_SETUP_FT. NFT
> framework already takes care of most of the locking. Document
> the assumptions.
> 
> [...]

Here is the summary with links:
  - [net-next] net: revert to lockless TC_SETUP_BLOCK and TC_SETUP_FT
    https://git.kernel.org/netdev/net-next/c/0a13c1e0a449

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html