netdev - Re: [PATCH net-next] netdevsim: 'support' multi-buf XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250312214222.0feb96ec@kernel.org>
Date: Wed, 12 Mar 2025 21:42:22 +0100
From: Jakub Kicinski <kuba@...nel.org>
To: Michal Kubiak <michal.kubiak@...el.com>
Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
 <sdf@...ichev.me>
Subject: Re: [PATCH net-next] netdevsim: 'support' multi-buf XDP

On Tue, 11 Mar 2025 11:51:31 +0100 Michal Kubiak wrote:
> > -	if (ns->netdev->mtu > NSIM_XDP_MAX_MTU) {
> > +	if (bpf->prog && !bpf->prog->aux->xdp_has_frags &&
> > +	    ns->netdev->mtu > NSIM_XDP_MAX_MTU) {
> >  		NSIM_EA(bpf->extack, "MTU too large w/ XDP enabled");  
> 
> Would it make sense to extend this error message to indicate that single-buf
> XDP is being used? For example: "MTU too large w/ single-buf XDP enabled"?
> (Please consider this as a suggestion only.)

Fair point, tho I'd rather push as is. It fixes the CI and some other
tests match on this exact error message so I'd need to fully retest 
the respin..