netdev - Re: [PATCH iwl-next 01/10] ice: move TSPLL functions to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a95dfb14-45d4-429f-8687-177c74428db1@intel.com>
Date: Wed, 12 Mar 2025 15:58:25 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Karol Kolacinski <karol.kolacinski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <przemyslaw.kitszel@...el.com>, Michal Kubiak
	<michal.kubiak@...el.com>, Milena Olech <milena-olech@...el.com>
Subject: Re: [PATCH iwl-next 01/10] ice: move TSPLL functions to a separate
 file



On 3/10/2025 4:12 AM, Karol Kolacinski wrote:
> Collect TSPLL related functions and definitions and move them to
> a separate file to have all TSPLL functionality in one place.
> 
> Move CGU related functions and definitions to ice_common.*

You lost changes with the move, specifically 4c9f13a65426 ("ice: use 
string choice helpers"). Please restore them. Also, please use the 
change/helper in patch 4.

Checkpatch reports missing SPDX:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1323: FILE: drivers/net/ethernet/intel/ice/ice_tspll.c:1:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1972: FILE: drivers/net/ethernet/intel/ice/ice_tspll.h:1:


> Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>
> Reviewed-by: Milena Olech <milena-olech@...el.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/Makefile       |   2 +-
>   drivers/net/ethernet/intel/ice/ice.h          |   1 +
>   drivers/net/ethernet/intel/ice/ice_cgu_regs.h | 181 -----
>   drivers/net/ethernet/intel/ice/ice_common.c   |  61 ++
>   drivers/net/ethernet/intel/ice/ice_common.h   | 176 +++++
>   drivers/net/ethernet/intel/ice/ice_ptp.c      |   1 -
>   .../net/ethernet/intel/ice/ice_ptp_consts.h   | 161 -----
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 542 ---------------
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  43 --
>   drivers/net/ethernet/intel/ice/ice_tspll.c    | 643 ++++++++++++++++++
>   drivers/net/ethernet/intel/ice/ice_tspll.h    |  43 ++
>   11 files changed, 925 insertions(+), 929 deletions(-)
>   delete mode 100644 drivers/net/ethernet/intel/ice/ice_cgu_regs.h
>   create mode 100644 drivers/net/ethernet/intel/ice/ice_tspll.c
>   create mode 100644 drivers/net/ethernet/intel/ice/ice_tspll.h