netdev - Re: [PATCH iwl-next 07/10] ice: add multiple TSPLL helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0347b9da-1b62-4763-849b-269a69135649@intel.com>
Date: Wed, 12 Mar 2025 16:08:55 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Karol Kolacinski <karol.kolacinski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <przemyslaw.kitszel@...el.com>, Michal Kubiak
	<michal.kubiak@...el.com>, Milena Olech <milena.olech@...el.com>
Subject: Re: [PATCH iwl-next 07/10] ice: add multiple TSPLL helpers



On 3/10/2025 4:12 AM, Karol Kolacinski wrote:

...

> +/**
> + * ice_tspll_default_freq - Return default frequency for a MAC type
> + * @mac_type: MAC type
> + */
> +static enum ice_tspll_freq ice_tspll_default_freq(enum ice_mac_type mac_type)

...

> +/**
> + * ice_tspll_check_params - Check if TSPLL params are correct
> + * @hw: Pointer to the HW struct
> + * @clk_freq: Clock frequency to program
> + * @clk_src: Clock source to select (TIME_REF or TCXO)
> + */

These two are missing 'Return:'

> +static bool ice_tspll_check_params(struct ice_hw *hw,
> +				   enum ice_tspll_freq clk_freq,
> +				   enum ice_clk_src clk_src)