netdev - [bug report] net: ti: icss-iep: Add pwidth configuration for perout signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b1c7c36-363a-4085-b26c-4f210bee1df6@stanley.mountain>
Date: Wed, 12 Mar 2025 11:30:49 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Meghana Malladi <m-malladi@...com>
Cc: netdev@...r.kernel.org
Subject: [bug report] net: ti: icss-iep: Add pwidth configuration for perout
 signal

Hello Meghana Malladi,

Commit e5b456a14215 ("net: ti: icss-iep: Add pwidth configuration for
perout signal") from Mar 4, 2025 (linux-next), leads to the following
Smatch static checker warning:

	drivers/net/ethernet/ti/icssg/icss_iep.c:825 icss_iep_exit()
	error: NULL dereference inside function icss_iep_perout_enable()

drivers/net/ethernet/ti/icssg/icss_iep.c
    815 {
    816         if (iep->ptp_clock) {
    817                 ptp_clock_unregister(iep->ptp_clock);
    818                 iep->ptp_clock = NULL;
    819         }
    820         icss_iep_disable(iep);
    821 
    822         if (iep->pps_enabled)
    823                 icss_iep_pps_enable(iep, false);
    824         else if (iep->perout_enabled)
--> 825                 icss_iep_perout_enable(iep, NULL, false);
                                                    ^^^^
Originally icss_iep_perout_enable() just returned -ENOTSUPP but now it
needs a valid "req" pointer.

    826 
    827         return 0;
    828 }

regards,
dan carpenter