netdev - Re: [PATCH v1 net] ipv6: Set errno after ip_fib_metrics_init() in ip6_route_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69218ae8-f10e-4d9b-9f60-dae863da11f0@kernel.org>
Date: Wed, 12 Mar 2025 10:36:57 +0100
From: David Ahern <dsahern@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>
Cc: Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net] ipv6: Set errno after ip_fib_metrics_init() in
 ip6_route_info_create().

On 3/12/25 2:38 AM, Kuniyuki Iwashima wrote:
> While creating a new IPv6, we could get a weird -ENOMEM when
> RTA_NH_ID is set and either of the conditions below is true:
> 
>   1) CONFIG_IPV6_SUBTREES is enabled and rtm_src_len is specified
>   2) nexthop_get() fails
> 
> e.g.)
> 
>   # strace ip -6 route add fe80::dead:beef:dead:beef nhid 1 from ::
>   recvmsg(3, {msg_iov=[{iov_base=[...[
>     {error=-ENOMEM, msg=[... [...]]},
>     [{nla_len=49, nla_type=NLMSGERR_ATTR_MSG}, "Nexthops can not be used with so"...]
>   ]], iov_len=32768}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, 0) = 148
> 
> Let's set err explicitly after ip_fib_metrics_init() in
> ip6_route_info_create().
> 
> Fixes: f88d8ea67fbd ("ipv6: Plumb support for nexthop object in a fib6_info")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
>  net/ipv6/route.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>