netdev - Re: [PATCH net-next v2] net: tulip: avoid unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250313105453.GA125266@kernel.org>
Date: Thu, 13 Mar 2025 11:54:53 +0100
From: Simon Horman <horms@...nel.org>
To: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Helge Deller <deller@....de>, netdev@...r.kernel.org,
	linux-parisc@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: tulip: avoid unused variable warning

On Thu, Mar 13, 2025 at 11:47:42AM +0100, Simon Horman wrote:
> There is an effort to achieve W=1 kernel builds without warnings.
> As part of that effort Helge Deller highlighted the following warnings
> in the tulip driver when compiling with W=1 and CONFIG_TULIP_MWI=n:
> 
>   .../tulip_core.c: In function ‘tulip_init_one’:
>   .../tulip_core.c:1309:22: warning: variable ‘force_csr0’ set but not used
> 
> This patch addresses that problem using IS_ENABLED(). This approach has
> the added benefit of reducing conditionally compiled code. And thus
> increasing compile coverage. E.g. for allmodconfig builds which enable
> CONFIG_TULIP_MWI.
> 
> Compile tested only.
> No run-time effect intended.
> 
> --
> 
> Acked-by: Helge Deller <deller@....de>
> Signed-off-by: Simon Horman <horms@...nel.org>
> v2: Use IS_ENABLED rather than __maybe_unused [Simon Horman]
> v1: Initial patch [Helge Deller]

Sorry, the tail of the commit message got a bit mangled.
I'll post a v3 after waiting for other feedback.

-- 
pw-bot: changes-requested