netdev - RE: [PATCH iwl-next v7 11/15] ixgbe: add device flash update via devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DS0PR11MB77858E6458594CB34A19B0D2F0D32@DS0PR11MB7785.namprd11.prod.outlook.com>
Date: Thu, 13 Mar 2025 11:20:35 +0000
From: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"R, Bharath" <bharath.r@...el.com>, "Mrozowicz, SlawomirX"
	<slawomirx.mrozowicz@...el.com>, "Kwapulinski, Piotr"
	<piotr.kwapulinski@...el.com>, "Wegrzyn, Stefan" <stefan.wegrzyn@...el.com>
Subject: RE: [PATCH iwl-next v7 11/15] ixgbe: add device flash update via
 devlink

From: Simon Horman <horms@...nel.org> 
Sent: Wednesday, March 12, 2025 3:56 PM

>On Wed, Mar 12, 2025 at 01:58:39PM +0100, Jedrzej Jagielski wrote:
>
>...
>
>> diff --git a/Documentation/networking/devlink/ixgbe.rst b/Documentation/networking/devlink/ixgbe.rst
>> index a41073a62776..41aedf4b8017 100644
>> --- a/Documentation/networking/devlink/ixgbe.rst
>> +++ b/Documentation/networking/devlink/ixgbe.rst
>> @@ -64,3 +64,27 @@ The ``ixgbe`` driver reports the following versions
>>        - running
>>        - 0xee16ced7
>>        - The first 4 bytes of the hash of the netlist module contents.
>> +
>> +Flash Update
>> +============
>> +The ``ixgbe`` driver implements support for flash update using the
>> +``devlink-flash`` interface. It supports updating the device flash using a
>> +combined flash image that contains the ``fw.mgmt``, ``fw.undi``, and
>> +``fw.netlist`` components.
>> +.. list-table:: List of supported overwrite modes
>> +   :widths: 5 95
>
>Hi Jedrzej,
>
>make htmldocs flags two warnings, which I believe can be resolved by
>adding a blank line here.
>
>  .../ixgbe.rst:75: ERROR: Unexpected indentation.
>  .../ixgbe.rst:76: WARNING: Field list ends without a blank line; unexpected unindent.

Hello Simon

thanks for finding these.

I will fix it and resend it later today probably.

>
>> +   * - Bits
>> +     - Behavior
>> +   * - ``DEVLINK_FLASH_OVERWRITE_SETTINGS``
>> +     - Do not preserve settings stored in the flash components being
>> +       updated. This includes overwriting the port configuration that
>> +       determines the number of physical functions the device will
>> +       initialize with.
>> +   * - ``DEVLINK_FLASH_OVERWRITE_SETTINGS`` and ``DEVLINK_FLASH_OVERWRITE_IDENTIFIERS``
>> +     - Do not preserve either settings or identifiers. Overwrite everything
>> +       in the flash with the contents from the provided image, without
>> +       performing any preservation. This includes overwriting device
>> +       identifying fields such as the MAC address, Vital product Data (VPD) area,
>> +       and device serial number. It is expected that this combination be used with an
>> +       image customized for the specific device.
>> +
>
>...