netdev - Re: [PATCH v6 02/10] property: Add functions to iterate named child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cb99c3d-6ea5-4c47-9e6c-d1a3966ad7ff@gmail.com>
Date: Thu, 13 Mar 2025 08:42:18 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Daniel Scally <djrscally@...il.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>,
 Claudiu Manoil <claudiu.manoil@....com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-acpi@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v6 02/10] property: Add functions to iterate named child

Hi Andy,

Thanks for the review.

On 10/03/2025 16:25, Andy Shevchenko wrote:
> On Mon, Mar 10, 2025 at 02:55:53PM +0200, Matti Vaittinen wrote:

...

>> +#define fwnode_for_each_named_child_node(fwnode, child, name)		\
>> +		fwnode_for_each_child_node(fwnode, child)		\
> 
> One TAB too much.
> 
>> +			if (!fwnode_name_eq(child, name)) { } else
> 
> Ditto.
> 
> Note, I believe this won't get v6.15-rc1, so there will be for_each_if()
> available and these will become

I'll use for_each_if() if I'll have to rebase this to the v6.15-rc1.

> But see above the proposed additional patch that you may include in your next
> version.

Seems like you sent it as it's own series. I believe it's better that way.

Yours,
	-- Matti