netdev - Re: [PATCH net-next v2 1/5] page_pool: Provide an empty page_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC_iWjJYGdZNWhYfLwBiDjo4R+gGcujDKpEbOdgaA0mTa9Vj3w@mail.gmail.com>
Date: Thu, 13 Mar 2025 16:40:12 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-rdma@...r.kernel.org, netdev@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew+netdev@...n.ch>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, Joe Damato <jdamato@...tly.com>, Leon Romanovsky <leon@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Saeed Mahameed <saeedm@...dia.com>, Simon Horman <horms@...nel.org>, 
	Tariq Toukan <tariqt@...dia.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Yunsheng Lin <linyunsheng@...wei.com>
Subject: Re: [PATCH net-next v2 1/5] page_pool: Provide an empty
 page_pool_stats for disabled stats.

Hi Sebastian

[...]

> @@ -81,6 +81,12 @@ static inline u64 *page_pool_ethtool_stats_get(u64 *data, const void *stats)
>  {
>         return data;
>  }
> +
> +static inline bool page_pool_get_stats(const struct page_pool *pool,
> +                                      struct page_pool_stats *stats)
> +{
> +       return false;
> +}

[...]

That looks reasonable. Unfortunately, we have some drivers that don't
check the result of this function, but I guess that is a driver-only
problem...

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>