netdev - Re: [PATCH net 5/7] net: ipv6: ila: fix lwtunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62a962f7-a91d-4338-9b18-d4073e83f814@uliege.be>
Date: Thu, 13 Mar 2025 15:48:20 +0100
From: Justin Iurman <justin.iurman@...ege.be>
To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
 kuba@...nel.org, horms@...nel.org, Tom Herbert <tom@...bertland.com>,
 Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net 5/7] net: ipv6: ila: fix lwtunnel_output() loop

On 3/13/25 13:46, Paolo Abeni wrote:
> On 3/11/25 3:12 PM, Justin Iurman wrote:
>> diff --git a/net/ipv6/ila/ila_lwt.c b/net/ipv6/ila/ila_lwt.c
>> index 7d574f5132e2..67f7c7015693 100644
>> --- a/net/ipv6/ila/ila_lwt.c
>> +++ b/net/ipv6/ila/ila_lwt.c
>> @@ -96,6 +96,14 @@ static int ila_output(struct net *net, struct sock *sk, struct sk_buff *skb)
>>   		}
>>   	}
>>   
>> +	/* avoid lwtunnel_output() reentry loop when destination is the same
>> +	 * after transformation
>> +	 */
>> +	if (orig_dst->lwtstate == dst->lwtstate) {
>> +		dst_release(dst);
>> +		return orig_dst->lwtstate->orig_output(net, sk, skb);
>> +	}
>> +
>>   	skb_dst_drop(skb);
>>   	skb_dst_set(skb, dst);
>>   	return dst_output(net, sk, skb);
> 
> Even this pattern is repeated verbatim in patch 3, and I think it should
> deserve a shared helper. Also a bit of a pity there are a few variations

+1 as well. However, same remark applies here: this patch (and some 
others) will be removed from this series in -v2.

> that do not fit cleanly a common helper, but I guess there is little to
> do about that for 'net'.

Indeed...

> Thanks,
> 
> Paolo
>