netdev - Re: [PATCH net-next] r8169: switch away from deprecated pcim_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f79bb045-1c2a-4a2e-8ed2-ff4ff4f9c814@intel.com>
Date: Thu, 13 Mar 2025 14:22:24 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Realtek linux nic maintainers
	<nic_swsd@...ltek.com>, Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni
	<pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, David Miller
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Simon Horman
	<horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: switch away from deprecated
 pcim_iomap_table



On 3/12/2025 12:21 PM, Heiner Kallweit wrote:
> Avoid using deprecated pcim_iomap_table by switching to
> pcim_iomap_region.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index b18daeeda..53e541ddb 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5447,11 +5447,10 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (region < 0)
>  		return dev_err_probe(&pdev->dev, -ENODEV, "no MMIO resource found\n");
>  
> -	rc = pcim_iomap_regions(pdev, BIT(region), KBUILD_MODNAME);
> -	if (rc < 0)
> -		return dev_err_probe(&pdev->dev, rc, "cannot remap MMIO, aborting\n");
> -
> -	tp->mmio_addr = pcim_iomap_table(pdev)[region];
> +	tp->mmio_addr = pcim_iomap_region(pdev, region, KBUILD_MODNAME);
> +	if (IS_ERR(tp->mmio_addr))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(tp->mmio_addr),
> +				     "cannot remap MMIO, aborting\n");
>  
>  	txconfig = RTL_R32(tp, TxConfig);
>  	if (txconfig == ~0U)

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>