netdev - Re: [PATCH net-next v2 0/9] net: stmmac: remove unnecessary of_get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73e82f1f-e0cc-4b1e-8436-727a268933f6@intel.com>
Date: Thu, 13 Mar 2025 15:48:39 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>, Andrew Lunn
	<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
CC: Alexandre Torgue <alexandre.torgue@...s.st.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Chen-Yu Tsai <wens@...e.org>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
	Jerome Brunet <jbrunet@...libre.com>, Kevin Hilman <khilman@...libre.com>,
	<linux-amlogic@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-arm-msm@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
	<linux-stm32@...md-mailman.stormreply.com>, <linux-sunxi@...ts.linux.dev>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Matthias Brugger
	<matthias.bgg@...il.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, "Neil
 Armstrong" <neil.armstrong@...aro.org>, <netdev@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>, Samuel Holland <samuel@...lland.org>, Vinod Koul
	<vkoul@...nel.org>
Subject: Re: [PATCH net-next v2 0/9] net: stmmac: remove unnecessary
 of_get_phy_mode() calls



On 3/12/2025 2:14 AM, Russell King (Oracle) wrote:
> Hi,
> 
> This series removes unnecessary of_get_phy_mode() calls from the stmmac
> glue drivers. stmmac_probe_config_dt() / devm_stmmac_probe_config_dt()
> already gets the interface mode using device_get_phy_mode() and stores
> it in plat_dat->phy_interface.
> 
> Therefore, glue drivers using of_get_phy_mode() are just duplicating
> the work that has already been done.
> 
> This series adjusts the glue drivers to remove their usage of
> of_get_phy_mode().
> 
> Changes in v2:
> - correct subject for patch 3
> - fix build error in patch 3
> - add attributations
> 

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 21 +++++++++------------
>  drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 12 ++++--------
>  .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c    |  8 +-------
>  drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c |  6 +-----
>  .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c |  4 +---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c      |  2 +-
>  drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c     | 12 ++++--------
>  drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c   |  8 +-------
>  drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c   |  6 +-----
>  9 files changed, 23 insertions(+), 56 deletions(-)
>