netdev - Re: [PATCH] igc: enable HW VLAN insertion/stripping by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALjTZvb_=NaNE=DS10G=61WK2xXQO35d2sYOd9L=qJ+TtpeeXg@mail.gmail.com>
Date: Thu, 13 Mar 2025 09:23:01 +0000
From: Rui Salvaterra <rsalvaterra@...il.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: Simon Horman <horms@...nel.org>, muhammad.husaini.zulkifli@...el.com, 
	przemyslaw.kitszel@...el.com, edumazet@...gle.com, kuba@...nel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] igc: enable HW VLAN insertion/stripping by default

Hi, Tony,

On Wed, 12 Mar 2025 at 21:43, Tony Nguyen <anthony.l.nguyen@...el.com> wrote:
>
> Unfortunately, I'm unable check with the original author or those
> involved at the time. From asking around it sounds like there may have
> been some initial issues when implementing this; my theory is this was
> off by default so that it would minimize the affects if additional
> issues were discovered.

I thought about that possibility, but in the end it didn't seem
logical to me. If the feature was WIP and/or broken in some way, why
would the user be allowed to enable it via ethtool, ever since it was
first implemented, in commit 8d7449630e3450bc0546dc0cb692fbb57d1852c0
(almost four years ago)?

> I see that you missed Intel Wired LAN (intel-wired-lan@...ts.osuosl.org)
> on the patch. Could you resend with the list included? Also, if you
> could make it 'PATCH iwl-next' to target the Intel -next tree as that
> seems the appropriate tree.

Oh. That list is marked as moderated, I (wrongly, for sure) assumed
there would be restrictions when mailing to it. I'll resend correctly
soon.

Kind regards,
Rui Salvaterra