netdev - Re: [PATCH net v2 1/3] devlink: fix xa_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fzsgorzowhkvegirdyqtum23fchn3ayicl54mg53n7tnrum2s4@fgidqht6kzvh>
Date: Fri, 14 Mar 2025 14:33:28 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, pierre@...ckhpc.com, 
	hkallweit1@...il.com, linux@...linux.org.uk, maxime.chevallier@...tlin.com, 
	christophe.leroy@...roup.eu, arkadiusz.kubalewski@...el.com, vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net v2 1/3] devlink: fix xa_alloc_cyclic() error handling

Wed, Mar 12, 2025 at 10:52:49AM +0100, michal.swiatkowski@...ux.intel.com wrote:
>In case of returning 1 from xa_alloc_cyclic() (wrapping) ERR_PTR(1) will
>be returned, which will cause IS_ERR() to be false. Which can lead to
>dereference not allocated pointer (rel).
>
>Fix it by checking if err is lower than zero.
>
>This wasn't found in real usecase, only noticed. Credit to Pierre.
>
>Fixes: c137743bce02 ("devlink: introduce object and nested devlink relationship infra")
>Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>