netdev - Re: [v4 PATCH 02/13] crypto: qat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9Q1euXeBy7x8zZI@gcabiddu-mobl.ger.corp.intel.com>
Date: Fri, 14 Mar 2025 13:56:10 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, "Richard
 Weinberger" <richard@....at>, Zhihao Cheng <chengzhihao1@...wei.com>,
	<linux-mtd@...ts.infradead.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
	Pavel Machek <pavel@....cz>, <linux-pm@...r.kernel.org>, Steffen Klassert
	<steffen.klassert@...unet.com>, <netdev@...r.kernel.org>
Subject: Re: [v4 PATCH 02/13] crypto: qat - Remove dst_null support

On Fri, Mar 14, 2025 at 08:22:26PM +0800, Herbert Xu wrote:
> Remove the unused dst_null support.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> ---
>  .../intel/qat/qat_common/qat_comp_algs.c      | 83 -------------------
>  1 file changed, 83 deletions(-)
> 
> diff --git a/drivers/crypto/intel/qat/qat_common/qat_comp_algs.c b/drivers/crypto/intel/qat/qat_common/qat_comp_algs.c
> index 2ba4aa22e092..9d5848e28ff8 100644
> --- a/drivers/crypto/intel/qat/qat_common/qat_comp_algs.c
> +++ b/drivers/crypto/intel/qat/qat_common/qat_comp_algs.c
> @@ -29,11 +29,6 @@ struct qat_compression_ctx {
...
> -static void qat_comp_resubmit(struct work_struct *work)
> -{
> -	struct qat_compression_req *qat_req =
> -		container_of(work, struct qat_compression_req, resubmit);
> -	struct qat_compression_ctx *ctx = qat_req->qat_compression_ctx;
> -	struct adf_accel_dev *accel_dev = ctx->inst->accel_dev;
> -	struct qat_request_buffs *qat_bufs = &qat_req->buf;
> -	struct qat_compression_instance *inst = ctx->inst;
> -	struct acomp_req *areq = qat_req->acompress_req;
> -	struct crypto_acomp *tfm = crypto_acomp_reqtfm(areq);
> -	unsigned int dlen = CRYPTO_ACOMP_DST_MAX;
> -	u8 *req = qat_req->req;
> -	dma_addr_t dfbuf;
> -	int ret;
> -
> -	areq->dlen = dlen;
> -
> -	dev_dbg(&GET_DEV(accel_dev), "[%s][%s] retry NULL dst request - dlen = %d\n",
> -		crypto_tfm_alg_driver_name(crypto_acomp_tfm(tfm)),
> -		qat_req->dir == COMPRESSION ? "comp" : "decomp", dlen);
> -
> -	ret = qat_bl_realloc_map_new_dst(accel_dev, &areq->dst, dlen, qat_bufs,
> -					 qat_algs_alloc_flags(&areq->base));
> -	if (ret)
> -		goto err;
The implementation of this function in qat/qat_common/qat_bl.c
should be removed as well as. After this change, it is not getting
called.

Thanks,

-- 
Giovanni