netdev - Re: [PATCH net-next 0/4] net: phy: remove calls to devm_hwmon_sanitize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250314182348.21ac024e@fedora-2.home>
Date: Fri, 14 Mar 2025 18:23:48 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Russell King - ARM Linux
 <linux@...linux.org.uk>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, David Miller
 <davem@...emloft.net>, Xu Liang <lxu@...linear.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jean Delvare
 <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] net: phy: remove calls to
 devm_hwmon_sanitize_name

Hi Heiner,

On Thu, 13 Mar 2025 20:43:44 +0100
Heiner Kallweit <hkallweit1@...il.com> wrote:

> Since c909e68f8127 ("hwmon: (core) Use device name as a fallback in
> devm_hwmon_device_register_with_info") we can simply provide NULL
> as name argument.
> 
> Heiner Kallweit (4):
>   net: phy: realtek: remove call to devm_hwmon_sanitize_name
>   net: phy: tja11xx: remove call to devm_hwmon_sanitize_name
>   net: phy: mxl-gpy: remove call to devm_hwmon_sanitize_name
>   net: phy: marvell-88q2xxx: remove call to devm_hwmon_sanitize_name
> 
>  drivers/net/phy/marvell-88q2xxx.c       |  8 +-------
>  drivers/net/phy/mxl-gpy.c               |  8 +-------
>  drivers/net/phy/nxp-tja11xx.c           | 19 +++++--------------
>  drivers/net/phy/realtek/realtek_hwmon.c |  7 +------
>  4 files changed, 8 insertions(+), 34 deletions(-)
> 

With more coffee in my system, I took a better look and it indeed looks
good to me.

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Sorry about the noisy comments,

Maxime