netdev - RE: [Intel-wired-lan] [PATCH iwl-net] ice: health.c: fix compilation on gcc 7.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ2PR11MB7518732AD8207483597D9997A0D22@SJ2PR11MB7518.namprd11.prod.outlook.com>
Date: Fri, 14 Mar 2025 07:03:36 +0000
From: "Mekala, SunithaX D" <sunithax.d.mekala@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Knitter, Konrad"
	<konrad.knitter@...el.com>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>, "Linus
 Torvalds" <torvalds@...ux-foundation.org>, Kees Cook <kees@...nel.org>, "Nick
 Desaulniers" <nick.desaulniers@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] ice: health.c: fix compilation
 on gcc 7.5

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Przemek Kitszel
> Sent: Wednesday, February 5, 2025 2:42 AM
> To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: netdev@...r.kernel.org; Knitter, Konrad <konrad.knitter@...el.com>; Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Zhuo, Qiuxu > <qiuxu.zhuo@...el.com>; Linus Torvalds <torvalds@...ux-foundation.org>; Kees Cook <kees@...nel.org>; Nick Desaulniers <nick.desaulniers@...il.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: health.c: fix compilation on gcc 7.5
>
>  GCC 7 is not as good as GCC 8+ in telling what is a compile-time const,
> and thus could be used for static storage. So we could not use variables
>  for that, no matter how much "const" keyword is sprinkled around.
>
> Excerpt from the report:
> My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0.
>
 >  CC [M]  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.o
> drivers/net/ethernet/intel/ice/devlink/health.c:35:3: error: initializer element is not constant
>   ice_common_port_solutions, {ice_port_number_label}},
>    ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/intel/ice/devlink/health.c:35:3: note: (near initialization for 'ice_health_status_lookup[0].solution')
> drivers/net/ethernet/intel/ice/devlink/health.c:35:31: error: initializer element is not constant
>   ice_common_port_solutions, {ice_port_number_label}},
>                                ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/intel/ice/devlink/health.c:35:31: note: (near initialization for 'ice_health_status_lookup[0].data_label[0]')
> drivers/net/ethernet/intel/ice/devlink/health.c:37:46: error: initializer element is not constant
>    "Change or replace the module or cable.", {ice_port_number_label}},
>                                               ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/intel/ice/devlink/health.c:37:46: note: (near initialization for 'ice_health_status_lookup[1].data_label[0]')
> drivers/net/ethernet/intel/ice/devlink/health.c:39:3: error: initializer element is not constant
>   ice_common_port_solutions, {ice_port_number_label}},
>   ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 85d6164ec56d ("ice: add fw and port health reporters")
> Reported-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> Closes: https://lore.kernel.org/netdev/CY8PR11MB7134BF7A46D71E50D25FA7A989F72@CY8PR11MB7134.namprd11.prod.outlook.com
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> I would really like to bump min gcc to 8.5 (RH 8 family),
> instead of supporting old Ubuntu. However SLES 15 is also stuck with gcc 7.5 :(
>
> CC: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: Kees Cook <kees@...nel.org>
> CC: Nick Desaulniers <nick.desaulniers@...il.com>
> ---
>  drivers/net/ethernet/intel/ice/devlink/health.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mekala@...el.com> (A Contingent worker at Intel)