[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAADnVQKrndZ25SuRj-Ofv8tA50XjTwVVyQWmasN94LT9zeV7JQ@mail.gmail.com>
Date: Fri, 14 Mar 2025 13:35:16 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Amery Hung <ameryhung@...il.com>
Cc: Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
Martin KaFai Lau <martin.lau@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>,
Jamal Hadi Salim <jhs@...atatu.com>, Kui-Feng Lee <sinquersw@...il.com>,
Toke Høiland-Jørgensen <toke@...hat.com>,
Jiri Pirko <jiri@...nulli.us>, Stanislav Fomichev <stfomichev@...il.com>,
ekarani.silvestre@....ufcg.edu.br, yangpeihao@...u.edu.cn,
Peilin Ye <yepeilin.cs@...il.com>, Kernel Team <kernel-team@...a.com>
Subject: Re: [PATCH bpf-next v5 12/13] selftests/bpf: Add a bpf fq qdisc to selftest
On Thu, Mar 13, 2025 at 12:03 PM Amery Hung <ameryhung@...il.com> wrote:
>
> From: Amery Hung <amery.hung@...edance.com>
>
> This test implements a more sophisticated qdisc using bpf. The bpf fair-
> queueing (fq) qdisc gives each flow an equal chance to transmit data. It
> also respects the timestamp of skb for rate limiting.
>
> Signed-off-by: Amery Hung <amery.hung@...edance.com>
> ---
> .../selftests/bpf/prog_tests/bpf_qdisc.c | 24 +
> .../selftests/bpf/progs/bpf_qdisc_fq.c | 718 ++++++++++++++++++
On the look of it, it's a pretty functional qdisc.
Since bpftool supports loading st_ops,
please list commands bpftool and tc the one can enter
to use this qdisc without running selftests.
Probably at the comment section at the top of bpf_qdisc_fq.c
It also needs SPDX and copyright.
pw-bot: cr
Powered by blists - more mailing lists