netdev - Re: [v4 PATCH 10/13] ubifs: Use crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4a51d32-0b04-2c27-924d-f3a54d6b63a5@huawei.com>
Date: Sat, 15 Mar 2025 13:08:21 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, Richard
 Weinberger <richard@....at>, <linux-mtd@...ts.infradead.org>, "Rafael J.
 Wysocki" <rafael@...nel.org>, Pavel Machek <pavel@....cz>,
	<linux-pm@...r.kernel.org>, Steffen Klassert <steffen.klassert@...unet.com>,
	<netdev@...r.kernel.org>
Subject: Re: [v4 PATCH 10/13] ubifs: Use crypto_acomp interface

在 2025/3/15 12:03, Herbert Xu 写道:
> On Sat, Mar 15, 2025 at 11:54:43AM +0800, Zhihao Cheng wrote:
>>
>> We get capi_name by 'crypto_acomp_alg_name(crypto_acomp_reqtfm(req))', not
>> compr->name.
> 
> It should return the same string.

The crypto_acomp_alg_name() gets name from compr->cc(the name is 
initialized by compr->capi_name).
I got the following messages after verifying:
[  154.907048] UBIFS warning (ubi0:0 pid 110): ubifs_compress_req.isra.0 
[ubifs]: cannot compress 4096 bytes, compressor deflate, error -12, 
leave data uncompressed

The 'deflate' is zlib compressor's capi_name, but we expect it be 'zlib' 
here.
> 
>> There are conflicts in patch 2 on the latest mainline version, can you
>> rebase this series so I can do some tests for UBIFS.
> 
> Thanks for testing! I've just pushed it to
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git acomp
> 
> So you should be able to pull that to test.
> 
> Cheers,
>