netdev - Re: [RFC PATCH 1/2] net: introduce per netns packet chains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKUYCXaUV3FS_2Ws2PU3Z+OimmaJGWLZNop9D+085pb2A@mail.gmail.com>
Date: Mon, 17 Mar 2025 11:46:07 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>
Subject: Re: [RFC PATCH 1/2] net: introduce per netns packet chains

On Mon, Mar 17, 2025 at 10:24 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 3/17/25 9:43 AM, Eric Dumazet wrote:
> > On Mon, Mar 17, 2025 at 9:40 AM Paolo Abeni <pabeni@...hat.com> wrote:
> >>
> >>
> >> Thanks Sabrina! I'll try to address the above in the next revision.
> >
> > Could you use dev_net_rcu() instead of dev_net() ?
>
> Indeed all the call site are under rcu - except the one in
> dev_queue_xmit_nit() that will need a little adjustment. I'll do in the
> next revision, thanks!

I think this patch makes a lot of sense, I would submit it as a standalone one ?

Second patch I honestly don't know yet :)